-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jdbc hw is done #82
base: main
Are you sure you want to change the base?
jdbc hw is done #82
Conversation
} catch (SQLException e) { | ||
throw new DataProcessingException("Can`t create book" + book, e); | ||
} | ||
return null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return null?
} | ||
} | ||
|
||
private Book dataTreatment(ResultSet resultSet) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dataTreatment? Choose more informative name. And it should contain a verb.
} | ||
|
||
private Book dataTreatment(ResultSet resultSet) { | ||
try { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete try and add throws to the signature
package mate.academy.exception; | ||
|
||
public class DataProcessingException extends RuntimeException { | ||
public DataProcessingException(String message, Throwable e) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
public DataProcessingException(String message, Throwable e) { | |
public DataProcessingException(String message, Throwable cause) { | |
No description provided.